Date: 2025-05-14
Time: 14:00–14:50
Room: Breakout Room 1
Level: Intermediate
Many people review patches on pgsql-hackers, but reviews from committers cary special weight because only a committer can execute the 'git push' command that makes someone's patch part of the official PostgreSQL source tree. But, what exactly is a committer doing when they review a patch with the intent of committing it? In this talk I'll discuss the strategies I use when reviewing and committing patches to PostgreSQL. There is probably a fair amount of variation among committers, so just because I do something in a certain way doesn't mean that everyone else does the same, and I'm not familiar with everyone else's practices, but where I know of specific differences, I'll attempt to highlight them. Along the way, I'll try to address the question of why committers are often very cautious about committing patches even when they seem to be good and well-written patches which implement things that would definitely be useful to the project.